Feature/platform metering config #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds comprehensive metering configuration support across all platform types (AWS, Azure, AKS, GCP, Kubernetes, OpenShift) in the Terraform provider. The changes enable users to configure platform-level metering settings including processing configurations, access credentials, and platform-specific metering parameters.
Key changes:
- Added metering configuration schemas for all supported platform types with processing options (timeline compaction and raw data deletion)
- Refactored platform configuration types into separate files for better code organization
- Updated secret obfuscation handling to support metering credentials alongside replication credentials
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/provider/schema_utils.go | Modified meshProjectRoleAttribute to accept a computed parameter for flexible usage across resource and data source schemas |
| internal/provider/platform_resource_schema_*.go | New files defining platform-specific schemas for Kubernetes, GCP, Azure, AWS, and AKS with metering support |
| internal/provider/platform_resource.go | Added shared meteringProcessingConfigSchema function and removed platform schemas moved to separate files |
| internal/provider/platform_data_source.go | Added metering configuration schemas for data sources and updated meshProjectRoleAttribute calls |
| internal/provider/platform_resource_obfuscationhandling.go | Extended secret obfuscation handling to support metering credentials |
| internal/provider/landingzone_resource.go | Updated meshProjectRoleAttribute calls with computed parameter |
| internal/modifiers/platformtypemodifier/validate_single_platform.go | Minor formatting improvements to error messages |
| docs/resources/platform.md | Updated documentation with metering configuration examples and reorganized schema sections |
| docs/data-sources/platform.md | Added metering configuration documentation for data sources |
| client/platform*.go | Refactored platform configuration structs into separate files with proper typing |
| .github/.copilot-instructions.md | Added guidelines for pointer and omitempty usage in data structures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
henryde
force-pushed
the
feature/platform-metering-config
branch
from
3a232b4 to
4fa8d52
Compare
henryde
force-pushed
the
feature/platform-metering-config
branch
from
9397b29 to
0b717b0
Compare
j0g3sc
approved these changes
Nov 18, 2025
Collaborator
j0g3sc
left a comment
j0g3sc
left a comment
There was a problem hiding this comment.
Looks good. I followed all the replication and metering config fields again and compared them to the kotlin definition.
Did a few tests locally as well and found no issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.